Overview
| Comment: | ChromeOS: Fix a potential free(NULL) in initialization of PCSC-NaCl |
|---|---|
| Downloads: | Tarball | ZIP archive | SQL archive |
| Timelines: | family | ancestors | descendants | both | trunk |
| Files: | files | file ages | folders |
| SHA1: |
5acacab0009aaaea5cb319348f8298c8 |
| User & Date: | rkeene on 2016-02-19 17:50:50 |
| Other Links: | manifest | tags |
Context
|
2016-02-26
| ||
| 16:23 | ChromeOS: Updated to delete the entire retry queue when we are done with it check-in: 42d0db67a2 user: rkeene tags: trunk | |
|
2016-02-19
| ||
| 17:50 | ChromeOS: Fix a potential free(NULL) in initialization of PCSC-NaCl check-in: 5acacab000 user: rkeene tags: trunk | |
| 17:50 | ChromeOS: Slightly better PCSC-NaCl initialization and enabled debugging in all projects check-in: c4916c27cd user: rkeene tags: trunk | |
Changes
Modified build/chrome/cackey-chrome-init.cc from [e1139896d5] to [84155dbf3d].
| ︙ | ︙ | |||
58 59 60 61 62 63 64 |
if (command.AsString() == "init") {
if (message->HasKey("smartcardManagerAppId")) {
smartcardManagerAppId = strdup(message->Get("smartcardManagerAppId").AsString().c_str());
}
pcscNaClInit(this, corePointer, smartcardManagerAppId, "CACKey");
| > | > | 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 |
if (command.AsString() == "init") {
if (message->HasKey("smartcardManagerAppId")) {
smartcardManagerAppId = strdup(message->Get("smartcardManagerAppId").AsString().c_str());
}
pcscNaClInit(this, corePointer, smartcardManagerAppId, "CACKey");
if (smartcardManagerAppId) {
free((void *) smartcardManagerAppId);
}
reply->Set("status", "success");
} else if (command.AsString() == "listcertificates") {
numCertificates = cackey_chrome_listCertificates(&certificates);
certificatesPPArray.SetLength(numCertificates);
|
| ︙ | ︙ |