Check-in [233d1929c2]
Overview
Comment:ChromeOS: Made PIN entry failure code slightly cleaner
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1: 233d1929c28893e43dd31b9c264ec96053130e48
User & Date: rkeene on 2016-02-13 10:08:53
Other Links: manifest | tags
Context
2016-02-13
10:09
ChromeOS: Whitespace cleanup check-in: 78f6a43a4e user: rkeene tags: trunk
10:08
ChromeOS: Made PIN entry failure code slightly cleaner check-in: 233d1929c2 user: rkeene tags: trunk
10:05
ChromeOS: Made PIN entry dialog much more robust check-in: 2c6a5fb7dd user: rkeene tags: trunk
Changes

Modified build/chrome/cackey.js from [5dbcaf75a3] to [e6983d567a].

128
129
130
131
132
133
134
135
136
137
138
139
140

141
142
143
144
145





146
147
148
149
150
151
152
153
154
128
129
130
131
132
133
134






135





136
137
138
139
140


141
142
143
144
145
146
147







-
-
-
-
-
-
+
-
-
-
-
-
+
+
+
+
+
-
-







				 * Register a handler to handle the window being closed without
				 * having sent anything
				 */
				pinWindow.onClosed.addListener(function() {
					if (pinWindowDidWork != 1) {
						console.log("[cackey] The PIN dialog was closed without resubmitting the request, treating it as a failure");

						cackeyMessageIncoming(
							{
								"data": {
									"target": "cackey",
									"command": messageEvent.data.command,
									"id": messageEvent.data.id,
						messageEvent.data.status = "error";
									"status": "error",
									"error": "PIN window closed without a PIN being provided"
								}
							}
						)
						messageEvent.data.error = "PIN window closed without a PIN being provided";

						cackeyMessageIncoming(messageEvent);
					}


					}
					return;
				})

				/*
				 * Pass this message off to the other window so that it may resubmit the request.
				 */
				pinWindow.contentWindow.parentWindow = window;