Check-in [2a4f67952b]
Overview
Comment:Added a toggle for disabling the Chrome PIN dialog
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1:2a4f67952be43c97ea472a41093d2953f099ee45
User & Date: rkeene on 2019-06-05 21:38:28
Other Links: manifest | tags
Context
2019-06-08
22:17
Use indexOf() instead of includes for backwards compatibility support check-in: 8b2206f04e user: rkeene tags: trunk
2019-06-06
21:56
Merged in trunk Leaf check-in: 8a375324e9 user: rkeene tags: ssh-agent-ui
2019-06-05
21:38
Added a toggle for disabling the Chrome PIN dialog check-in: 2a4f67952b user: rkeene tags: trunk
21:35
Potentially better PIN handling check-in: e5a1e29b79 user: rkeene tags: trunk
Changes

Modified build/chrome/cackey.js from [b238d95675] to [21d583c591].

     8      8   	return;
     9      9   }
    10     10   
    11     11   /*
    12     12    * Optional features for CACKey
    13     13    */
    14     14   var cackeyFeatures = {
    15         -	customPINPrompt: true
           15  +	customPINPrompt: true,
           16  +	useChromePINDialog: true
    16     17   };
    17     18   
    18     19   /*
    19     20    * Handle for the CACKey NaCl Target
    20     21    */
    21     22   var cackeyHandle = null;
    22     23   var cackeyPCSCHandle = null;
................................................................................
   319    320   
   320    321   			/*
   321    322   			 * Set the handle to an invalid (but non-null) value until the window
   322    323   			 * is created in case we are invoked again soon.
   323    324   			 */
   324    325   			pinWindowPreviousHandle = "invalid";
   325    326   
   326         -			if (messageEvent.data.originalrequest.signRequestId === null) {
          327  +			if (messageEvent.data.originalrequest.signRequestId === null || cackeyFeatures.useChromePINDialog === false) {
   327    328   				chrome.app.window.create("pin.html", {
   328    329   					"id": "cackeyPINEntry",
   329    330   					"resizable": false,
   330    331   					"alwaysOnTop": true,
   331    332   					"focused": true,
   332    333   					"visibleOnAllWorkspaces": true,
   333    334   					"innerBounds": {