Index: cackey.c ================================================================== --- cackey.c +++ cackey.c @@ -711,10 +711,11 @@ struct cackey_identity *decrypt_identity; }; struct cackey_slot { int active; + int internal; char *pcsc_reader; int pcsc_card_connected; SCARDHANDLE pcsc_card; @@ -855,10 +856,15 @@ uint32_t idx; CACKEY_DEBUG_PRINTF("Called."); for (idx = 0; idx < (sizeof(cackey_slots) / sizeof(cackey_slots[0])); idx++) { + if (cackey_slots[idx].internal) { + /* Skip internal slots */ + continue; + } + if (cackey_slots[idx].pcsc_card_connected) { CACKEY_DEBUG_PRINTF("SCardDisconnect(%lu) called", (unsigned long) idx); SCardDisconnect(cackey_slots[idx].pcsc_card, SCARD_LEAVE_CARD); } @@ -2604,10 +2610,16 @@ DWORD reader_len, state, protocol, atr_len; BYTE atr[MAX_ATR_SIZE]; LONG status_ret, scard_reconn_ret; CACKEY_DEBUG_PRINTF("Called."); + + if (slot->internal) { + CACKEY_DEBUG_PRINTF("Returning token present (internal token)"); + + return(CACKEY_PCSC_S_TOKENPRESENT); + } pcsc_connect_ret = cackey_connect_card(slot); if (pcsc_connect_ret != CACKEY_PCSC_S_OK) { CACKEY_DEBUG_PRINTF("Unable to connect to card, returning token absent"); @@ -3403,40 +3415,52 @@ static struct cackey_identity *cackey_read_identities(struct cackey_slot *slot, unsigned long *ids_found) { struct cackey_pcsc_identity *pcsc_identities; struct cackey_identity *identities; unsigned long num_ids, id_idx, curr_id_type; - unsigned long num_certs, num_extra_certs, cert_idx; - int include_extra_certs = 1; + unsigned long num_certs, num_dod_certs, cert_idx; CACKEY_DEBUG_PRINTF("Called."); - if (getenv("CACKEY_NO_EXTRA_CERTS") != NULL) { - CACKEY_DEBUG_PRINTF("Asked not to include extra (DoD) certificates"); - - include_extra_certs = 0; - } - - if (include_extra_certs) { - num_extra_certs = sizeof(extra_certs) / sizeof(extra_certs[0]); - - CACKEY_DEBUG_PRINTF("Including %li DoD Certificates as objects on this token", num_extra_certs); - } else { - num_extra_certs = 0; - } - if (ids_found == NULL) { CACKEY_DEBUG_PRINTF("Error. ids_found is NULL"); return(NULL); } + + if (slot->internal) { + /* Add DoD Certificates and Netscape Trust Objects */ + num_dod_certs = sizeof(extra_certs) / sizeof(extra_certs[0]); + + num_ids = num_dod_certs * 3; + + identities = malloc(num_ids * sizeof(*identities)); + + id_idx = 0; + for (cert_idx = 0; cert_idx < num_dod_certs; cert_idx++) { + identities[id_idx].pcsc_identity = NULL; + identities[id_idx].attributes = cackey_get_attributes(CKO_CERTIFICATE, &extra_certs[cert_idx], 0xf000 | cert_idx, &identities[id_idx].attributes_count); + id_idx++; + + identities[id_idx].pcsc_identity = NULL; + identities[id_idx].attributes = cackey_get_attributes(CKO_PUBLIC_KEY, &extra_certs[cert_idx], 0xf000 | cert_idx, &identities[id_idx].attributes_count); + id_idx++; + + identities[id_idx].pcsc_identity = NULL; + identities[id_idx].attributes = cackey_get_attributes(CKO_NETSCAPE_TRUST, &extra_certs[cert_idx], 0xf000 | cert_idx, &identities[id_idx].attributes_count); + id_idx++; + } + + *ids_found = num_ids; + + return(identities); + } pcsc_identities = cackey_read_certs(slot, NULL, &num_certs); if (pcsc_identities != NULL) { /* Convert number of Certs to number of objects */ num_ids = (CKO_PRIVATE_KEY - CKO_CERTIFICATE + 1) * num_certs; - num_ids += num_extra_certs * 3; identities = malloc(num_ids * sizeof(*identities)); /* Add certificates, public keys, and private keys from the smartcard */ id_idx = 0; @@ -3454,36 +3478,22 @@ } } cackey_free_certs(pcsc_identities, num_certs, 1); - /* Add DoD Certificates and Netscape Trust Objects */ - for (cert_idx = 0; cert_idx < num_extra_certs; cert_idx++) { - identities[id_idx].pcsc_identity = NULL; - identities[id_idx].attributes = cackey_get_attributes(CKO_CERTIFICATE, &extra_certs[cert_idx], 0xf000 | cert_idx, &identities[id_idx].attributes_count); - id_idx++; - - identities[id_idx].pcsc_identity = NULL; - identities[id_idx].attributes = cackey_get_attributes(CKO_PUBLIC_KEY, &extra_certs[cert_idx], 0xf000 | cert_idx, &identities[id_idx].attributes_count); - id_idx++; - - identities[id_idx].pcsc_identity = NULL; - identities[id_idx].attributes = cackey_get_attributes(CKO_NETSCAPE_TRUST, &extra_certs[cert_idx], 0xf000 | cert_idx, &identities[id_idx].attributes_count); - id_idx++; - } - *ids_found = num_ids; + return(identities); } *ids_found = 0; return(NULL); } CK_DEFINE_FUNCTION(CK_RV, C_Initialize)(CK_VOID_PTR pInitArgs) { CK_C_INITIALIZE_ARGS CK_PTR args; - uint32_t idx; + uint32_t idx, highest_slot; int mutex_init_ret; CACKEY_DEBUG_PRINTF("Called."); if (cackey_initialized) { @@ -3521,10 +3531,25 @@ cackey_slots[idx].transaction_depth = 0; cackey_slots[idx].transaction_need_hw_lock = 0; cackey_slots[idx].slot_reset = 0; cackey_slots[idx].token_flags = 0; cackey_slots[idx].label = NULL; + cackey_slots[idx].internal = 0; + } + + if (getenv("CACKEY_NO_EXTRA_CERTS") != NULL) { + CACKEY_DEBUG_PRINTF("Asked not to include DoD certificates"); + } else { + highest_slot = (sizeof(cackey_slots) / sizeof(cackey_slots[0])) - 1; + + CACKEY_DEBUG_PRINTF("Including DoD certs in slot %lu", (unsigned long) highest_slot); + + cackey_slots[highest_slot].active = 1; + cackey_slots[highest_slot].internal = 1; + cackey_slots[highest_slot].label = (unsigned char *) "DoD Certificates"; + cackey_slots[highest_slot].pcsc_reader = "CACKey"; + cackey_slots[highest_slot].token_flags = 0; } cackey_initialized = 1; if (!cackey_biglock_init) { @@ -3568,10 +3593,14 @@ } cackey_slots_disconnect_all(); for (idx = 0; idx < (sizeof(cackey_slots) / sizeof(cackey_slots[0])); idx++) { + if (cackey_slots[idx].internal) { + continue; + } + if (cackey_slots[idx].pcsc_reader) { free(cackey_slots[idx].pcsc_reader); } } @@ -3625,11 +3654,11 @@ * Process list of readers, and create mapping between reader name and slot ID */ CK_DEFINE_FUNCTION(CK_RV, C_GetSlotList)(CK_BBOOL tokenPresent, CK_SLOT_ID_PTR pSlotList, CK_ULONG_PTR pulCount) { int mutex_retval; int pcsc_connect_ret; - CK_ULONG count, slot_count = 0, currslot; + CK_ULONG count, slot_count = 0, currslot, slot_idx; char *pcsc_readers, *pcsc_readers_s, *pcsc_readers_e; DWORD pcsc_readers_len; LONG scard_listreaders_ret; size_t curr_reader_len; @@ -3660,10 +3689,14 @@ /* Only update the list of slots if we are actually being supply the slot information */ cackey_slots_disconnect_all(); for (currslot = 0; currslot < (sizeof(cackey_slots) / sizeof(cackey_slots[0])); currslot++) { + if (cackey_slots[currslot].internal) { + continue; + } + if (cackey_slots[currslot].pcsc_reader) { free(cackey_slots[currslot].pcsc_reader); cackey_slots[currslot].pcsc_reader = NULL; } @@ -3708,11 +3741,19 @@ pcsc_readers_e = pcsc_readers + pcsc_readers_len; /* Start with Slot ID 1, to avoid a bug in GDM on RHEL */ /* Bug 594911: https://bugzilla.redhat.com/show_bug.cgi?id=594911 */ currslot = 1; + slot_count = 0; while (pcsc_readers < pcsc_readers_e) { + /* Find next available slot */ + for (; currslot < (sizeof(cackey_slots) / sizeof(cackey_slots[0])); currslot++) { + if (!cackey_slots[currslot].active) { + break; + } + } + curr_reader_len = strlen(pcsc_readers); if ((pcsc_readers + curr_reader_len) > pcsc_readers_e) { break; } @@ -3730,31 +3771,35 @@ CACKEY_DEBUG_PRINTF("Found reader: %s", pcsc_readers); /* Only update the list of slots if we are actually being asked supply the slot information */ if (pSlotList) { cackey_slots[currslot].active = 1; + cackey_slots[currslot].internal = 0; cackey_slots[currslot].pcsc_reader = strdup(pcsc_readers); cackey_slots[currslot].pcsc_card_connected = 0; cackey_slots[currslot].transaction_depth = 0; cackey_slots[currslot].transaction_need_hw_lock = 0; cackey_slots[currslot].slot_reset = 1; cackey_slots[currslot].token_flags = CKF_LOGIN_REQUIRED; cackey_slots[currslot].label = NULL; cackey_mark_slot_reset(&cackey_slots[currslot]); + } else { + /* Artificially increase the number of active slots by what will become active */ + slot_count++; } currslot++; pcsc_readers += curr_reader_len + 1; } - /* Start with Slot ID 1, to avoid a bug in GDM on RHEL */ - /* Bug 594911: https://bugzilla.redhat.com/show_bug.cgi?id=594911 */ - if (currslot > 1) { - /* Start with Slot ID 1, to avoid a bug in GDM on RHEL */ - /* Bug 594911: https://bugzilla.redhat.com/show_bug.cgi?id=594911 */ - slot_count = currslot - 1; + for (currslot = 0; currslot < (sizeof(cackey_slots) / sizeof(cackey_slots[0])); currslot++) { + if (cackey_slots[currslot].active) { + CACKEY_DEBUG_PRINTF("Found active slot %lu", (unsigned long) currslot); + + slot_count++; + } } } else { CACKEY_DEBUG_PRINTF("Second call to SCardListReaders failed, return %s/%li", CACKEY_DEBUG_FUNC_SCARDERR_TO_STR(scard_listreaders_ret), (long) scard_listreaders_ret); } @@ -3781,17 +3826,43 @@ count = *pulCount; if (count < slot_count) { CACKEY_DEBUG_PRINTF("Error. User allocated %lu entries, but we have %lu entries.", count, slot_count); + CACKEY_DEBUG_PRINTF("Returning CKR_BUFFER_TOO_SMALL"); + return(CKR_BUFFER_TOO_SMALL); } - for (currslot = 0; currslot < slot_count; currslot++) { - /* Start with Slot ID 1, to avoid a bug in GDM on RHEL */ - /* Bug 594911: https://bugzilla.redhat.com/show_bug.cgi?id=594911 */ - pSlotList[currslot] = currslot + 1; + mutex_retval = cackey_mutex_lock(cackey_biglock); + if (mutex_retval != 0) { + CACKEY_DEBUG_PRINTF("Error. Locking failed."); + + return(CKR_GENERAL_ERROR); + } + + slot_idx = 0; + for (currslot = 0; (currslot < (sizeof(cackey_slots) / sizeof(cackey_slots[0]))); currslot++) { + if (!cackey_slots[currslot].active) { + continue; + } + + if (slot_idx >= count) { + CACKEY_DEBUG_PRINTF("Error. User allocated %lu entries, but we just tried to write to the %lu index -- ignoring", count, slot_idx); + + continue; + } + + pSlotList[slot_idx] = currslot; + slot_idx++; + } + + mutex_retval = cackey_mutex_unlock(cackey_biglock); + if (mutex_retval != 0) { + CACKEY_DEBUG_PRINTF("Error. Unlocking failed."); + + return(CKR_GENERAL_ERROR); } *pulCount = slot_count; CACKEY_DEBUG_PRINTF("Returning CKR_OK (%i). Found %lu readers.", CKR_OK, (unsigned long) slot_count); @@ -3839,11 +3910,15 @@ cackey_mutex_unlock(cackey_biglock); return(CKR_SLOT_ID_INVALID); } - pInfo->flags = CKF_REMOVABLE_DEVICE | CKF_HW_SLOT; + pInfo->flags = CKF_HW_SLOT; + + if (!cackey_slots[slotID].internal) { + pInfo->flags |= CKF_REMOVABLE_DEVICE; + } if (cackey_token_present(&cackey_slots[slotID]) == CACKEY_PCSC_S_TOKENPRESENT) { pInfo->flags |= CKF_TOKEN_PRESENT; } Index: test.c ================================================================== --- test.c +++ test.c @@ -236,10 +236,11 @@ chk_rv = C_GetSlotInfo(slots[currSlot], &slotInfo); if (chk_rv != CKR_OK) { return(1); } + printf(" Id : %lu\n", (unsigned long) slots[currSlot]); printf(" Desc : %.*s\n", 32, slotInfo.slotDescription); printf(" ManufID: %.*s\n", 32, slotInfo.manufacturerID); printf(" HWVers : %i.%i\n", slotInfo.hardwareVersion.major, slotInfo.hardwareVersion.minor); printf(" FWVers : %i.%i\n", slotInfo.firmwareVersion.major, slotInfo.firmwareVersion.minor); printf(" Flags : "); @@ -327,10 +328,15 @@ } } chk_rv = C_OpenSession(slots[0], CKF_SERIAL_SESSION, NULL, NULL, &hSession); if (chk_rv == CKR_OK) { + chk_rv = C_GetTokenInfo(slots[0], &tokenInfo); + if (chk_rv != CKR_OK) { + return(1); + } + if ((tokenInfo.flags & CKF_LOGIN_REQUIRED) == CKF_LOGIN_REQUIRED) { fgets_ret = NULL; while (fgets_ret == NULL) { printf("** ENTER PIN: ");